Fix [p]play for Spotify links with regional codes#6700
Open
Simo62bit wants to merge 1 commit intoCog-Creators:V3/developfrom
Open
Fix [p]play for Spotify links with regional codes#6700Simo62bit wants to merge 1 commit intoCog-Creators:V3/developfrom
Simo62bit wants to merge 1 commit intoCog-Creators:V3/developfrom
Conversation
In audio_dataclasses.py (cogs/audio/apis), modified the Spotify URL regex: _RE_SPOTIFY_URL: Final[Pattern] = re.compile(r"(http[s]?://)?(open\.spotify\.com)/") to: _RE_SPOTIFY_URL: Final[Pattern] = re.compile(r"(http[s]?://)?(open\.spotify\.com)/(?:intl-[a-zA-Z-]+/)?") This ensures that URLs like: !play https://open.spotify.com/intl-it/track/4KilYheWwxakB1L43ECTeP?si=... are correctly converted to: spotify:track:4KilYheWwxakB1L43ECTeP instead of incorrectly including the regional code (e.g., spotify:intl-it:track:...).
github-actions
bot
added
the
Category: Cogs - Audio
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the changes
In audio_dataclasses.py (cogs/audio/apis), modified the Spotify URL regex:
_RE_SPOTIFY_URL: Final[Pattern] = re.compile(r"(http[s]?://)?(open.spotify.com)/")
to:
_RE_SPOTIFY_URL: Final[Pattern] = re.compile(r"(http[s]?://)?(open.spotify.com)/(?:intl-[a-zA-Z-]+/)?")
This ensures that URLs like:
!play https://open.spotify.com/intl-it/track/4KilYheWwxakB1L43ECTeP?si=...
are correctly converted to:
spotify:track:4KilYheWwxakB1L43ECTeP
instead of incorrectly including the regional code (e.g., spotify:intl-it:track:...).
Fixes #6446
Have the changes in this PR been tested?
Yes